feat: Temporarily negate ProjectAuthenticationWarning when using Project.is_shared()#610
Merged
faretek1 merged 3 commits intoTimMcCool:mainfrom May 10, 2026
Merged
feat: Temporarily negate ProjectAuthenticationWarning when using Project.is_shared()#610faretek1 merged 3 commits intoTimMcCool:mainfrom
ProjectAuthenticationWarning when using Project.is_shared()#610faretek1 merged 3 commits intoTimMcCool:mainfrom
Conversation
Signed-off-by: Boss_1s <95505913+Boss-1s@users.noreply.github.com>
Signed-off-by: Boss_1s <95505913+Boss-1s@users.noreply.github.com>
Collaborator
|
This does work and is probably the simplest way to make it work |
TheCommCraft
approved these changes
May 10, 2026
faretek1
approved these changes
May 10, 2026
| p = get_project(self.id) | ||
| return isinstance(p, Project) | ||
| except exceptions.ProjectNotFound: | ||
| response = requests.get(f"https://api.scratch.mit.edu/projects/{self.id}") |
Collaborator
There was a problem hiding this comment.
We could use self.update_api and self.update_method here although this isn't technically an update method so maybe it should be decoupled. But this is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #592
Changes
Project.get_project'sProjectAuthenticationWarningusingwarnings.catch_warnings()Tests
Tested in CPython 3.12.1 REPL